Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] NO-JIRA: Fix templates config test #708

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] NO-JIRA: Fix templates config test #708

wants to merge 1 commit into from

Conversation

liouk
Copy link
Member

@liouk liouk commented Oct 3, 2024 •
edited
Loading

Due to the enhanced routing patterns of go 1.22, and because with multiple providers the provider's name is used as part of the login url (/login/<provider-name>), it is now impossible to use provider names that include spaces.

This PR fixes a test that uses spaces in its provider name.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2024
@openshift-ci-robot
Copy link
Contributor

@liouk: This pull request explicitly references no jira issue.

In response to this:

Due to the new pattern matching of net/http.ServeMux in go 1.23, and because with multiple providers the provider's name is used as part of the login url (/login/<provider-name>), it is now impossible to use provider names that include spaces.

This PR fixes a test that uses spaces in its provider name.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and ibihim October 3, 2024 14:22
@liouk
Copy link
Member Author

liouk commented Oct 3, 2024

/retest-required

2 similar comments
@liouk
Copy link
Member Author

liouk commented Oct 3, 2024

/retest-required

@liouk
Copy link
Member Author

liouk commented Oct 4, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024 •
edited
Loading

@liouk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ipv6 bdc4503 link false /test e2e-agnostic-ipv6
ci/prow/e2e-aws-single-node bdc4503 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ibihim
Copy link
Contributor

ibihim commented Oct 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibihim, liouk
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liouk
Copy link
Member Author

liouk commented Oct 8, 2024

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@ibihim ibihim Awaiting requested review from ibihim

Assignees

@ibihim ibihim

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liouk @openshift-ci-robot @ibihim